Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic pager in message lists #6090

Merged
merged 3 commits into from Jul 9, 2019

Conversation

@kmerz
Copy link
Member

commented Jul 5, 2019

Description

Only display the pager in message lists, when the amount of messages is bigger
than the page size.

Motivation and Context

We right now always show a pager, even though we never need it, since the we only
ask for max 150 messages and the page size 150.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
kmerz added 2 commits Jul 5, 2019

@kmerz kmerz added this to the 3.1.0 milestone Jul 5, 2019

position="top"
resultCount={messages.length} />
</div>
{ messages.length > Messages.DEFAULT_LIMIT

This comment has been minimized.

Copy link
@dennisoelkers

dennisoelkers Jul 8, 2019

Member

I think this should be messages.length > pageSize?

@dennisoelkers dennisoelkers merged commit 306b91c into master Jul 9, 2019

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 3847 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 4562 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@dennisoelkers dennisoelkers deleted the dynamic_pager branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.