Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide parameter bindings when using message list pagination #7672

Closed
wants to merge 4 commits into from

Conversation

linuspahl
Copy link
Contributor

As described in #7665 using the message list pagination throws an error, when the query contains a parameter. With these changes we always require the parameter bindings when re-executing the search.

Note: This PR requires a backport for 3.2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@linuspahl
Copy link
Contributor Author

I will create another PR which also fixes: #7680

@linuspahl linuspahl closed this Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant