Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color variant adjust #7971

Merged
merged 2 commits into from Apr 28, 2020
Merged

Color variant adjust #7971

merged 2 commits into from Apr 28, 2020

Conversation

kyleknighted
Copy link
Contributor

Description

Updating variant light and dark colors to generate based on gray shades.

Motivation and Context

Keep the colors more in range of the theme and needing broader spectrum in shades.

Screenshots (if appropriate):

###Before
image

After

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@ousmaneo ousmaneo self-assigned this Apr 28, 2020
ousmaneo
ousmaneo approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@ousmaneo ousmaneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good!

@ousmaneo ousmaneo merged commit c2caf85 into master Apr 28, 2020
@ousmaneo ousmaneo deleted the color_variant_adjust branch April 28, 2020 07:22
@kyleknighted kyleknighted mentioned this pull request Apr 28, 2020
Merged
9 tasks
@kyleknighted kyleknighted mentioned this pull request May 8, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousmaneo ousmaneo ousmaneo approved these changes

@linuspahl linuspahl Awaiting requested review from linuspahl

Assignees

@ousmaneo ousmaneo

Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kyleknighted @ousmaneo