Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme.color to theme.colors #8176

Merged
merged 6 commits into from Jun 9, 2020
Merged

theme.color to theme.colors #8176

merged 6 commits into from Jun 9, 2020

Conversation

kyleknighted
Copy link
Contributor

@kyleknighted kyleknighted commented May 21, 2020 •
edited

Description

rename theme.color to theme.colors because I was annoying myself with spreading unnecessarily
Keeping things consistent

Motivation and Context

Cleaning up code

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@kyleknighted kyleknighted requested a review from a team May 21, 2020 18:01
kyleknighted added a commit that referenced this pull request May 21, 2020
@kyleknighted
theme.color to theme.colors #8176
e19c3ea
@linuspahl
Copy link
Contributor

Looks good to me, I prefer colors over color as well. I will merge this PR when the merge conflicts got resolved.

kyleknighted added a commit that referenced this pull request Jun 8, 2020
@kyleknighted
theme.color to theme.colors #8176
4c254ce
kyleknighted added a commit that referenced this pull request Jun 8, 2020
@kyleknighted
theme.color to theme.colors #8176
47cdc40
kyleknighted added a commit that referenced this pull request Jun 9, 2020
@kyleknighted
theme.color to theme.colors #8176
29aa8bb
kyleknighted added a commit that referenced this pull request Jun 9, 2020
@kyleknighted
theme.color to theme.colors #8176
085e2e8
kmerz
kmerz approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@kmerz kmerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍
Worked after testing 👍

linuspahl
linuspahl approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@linuspahl linuspahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well!

@linuspahl linuspahl merged commit 34c076d into master Jun 9, 2020
@linuspahl linuspahl deleted the color_to_colors branch June 9, 2020 15:32
@kyleknighted kyleknighted mentioned this pull request Jun 10, 2020
Merged
linuspahl pushed a commit that referenced this pull request Jun 11, 2020
@kyleknighted @linuspahl
theme.color to theme.colors (#8176)
76c316d 
* theme.color` to `theme.colors #8176

* Cleanup

* snapshots

* lint

* theme mode

* snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmerz kmerz kmerz approved these changes

@linuspahl linuspahl linuspahl approved these changes

Assignees
No one assigned
Labels
ready-for-review User Experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kyleknighted @linuspahl @kmerz