Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add if-plugins to native models #491

Conversation

alexzurbonsen
Copy link
Contributor

@alexzurbonsen alexzurbonsen commented Mar 3, 2024

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

This PR adds if-plugins to the native plugins.

@jmcook1186
Copy link
Contributor

Hi @alexzurbonsen - if-models is actually removed in our latest refactor. The only change needed here is renaming if-models to if-plugins.

@alexzurbonsen
Copy link
Contributor Author

Okay, makes sense to me. That also was what I did at first, but then I thought that it might be nice to cover legacy models as well.

But I can remove that of course.

@alexzurbonsen alexzurbonsen force-pushed the add-to-native-modules branch 2 times, most recently from 760d060 to f6189fc Compare March 4, 2024 19:24
Signed-off-by: alexzurbonsen <alexander.zur.bonsen@tngtech.com>
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@narekhovhannisyan narekhovhannisyan merged commit 07ce0d1 into Green-Software-Foundation:main Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants