Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip single bad record #8

Merged
merged 2 commits into from
Apr 5, 2022
Merged

skip single bad record #8

merged 2 commits into from
Apr 5, 2022

Conversation

Kpoke
Copy link
Collaborator

@Kpoke Kpoke commented Apr 2, 2022

Skip single bad record rather than the entire file

@Kpoke Kpoke requested a review from ZavenArra April 2, 2022 23:00
Copy link
Contributor

@ZavenArra ZavenArra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, a single bad record will not stop processing the full pack, but also the full pack still get marked as 'processed=true'. It should remain processed to false.

@Kpoke Kpoke requested a review from ZavenArra April 5, 2022 20:33
@Kpoke
Copy link
Collaborator Author

Kpoke commented Apr 5, 2022

Added a boolean flag that would be set to false if an error occurs and that would be used to determine whether or not to set processed to true

@ZavenArra ZavenArra merged commit 28e2eea into Greenstand:main Apr 5, 2022
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

🎉 This PR is included in version 1.2.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants