Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint and Reformat Code #1089

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Lint and Reformat Code #1089

merged 3 commits into from
Apr 21, 2023

Conversation

CalebKL
Copy link
Contributor

@CalebKL CalebKL commented Apr 19, 2023

This PR lints and reformats code by using these plugins/commands

ktlintFormat
ktlintCheck
detekt
spotlessApply

I also introduced two files :

  1. TD.md which has some tech debt that we need to address with time
  2. and a pull_request_template

@Elforama
Copy link
Contributor

Aside from the new files, are all the file modifications from the automatic reformatting?

@CalebKL
Copy link
Contributor Author

CalebKL commented Apr 20, 2023

The files that are added are:

  1. pull_request_template.md
  2. editorConfig
  3. detekt.yml
  4. TD.md

Files modified:

  1. root gradle to add the necessary dependencies
  2. codeAnalysis.sh to add the commands and refactored the name
  3. ObjectStorageClient - To supress ImplicitDefaultLocale rule

All other files are automatic reformatting

@Elforama Elforama merged commit df4c7c1 into Greenstand:master Apr 21, 2023
1 check passed
@CalebKL CalebKL deleted the lintcleanup branch April 21, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants