Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config screen #1090

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Add config screen #1090

merged 1 commit into from
Apr 25, 2023

Conversation

Elforama
Copy link
Contributor

Adds a debug screen to turn on/off different features for testing and release. This will later hook up to RemoteConfig from Firebase.

@EngrTaofeek
Copy link
Collaborator

I love this idea, really a great way to compare different features while testing. I tried tracking the trees did the first three without forcing image size and the last three while forcing image size. I noticed all six were in same resolution(1088 x 1920) and about same size (177.6kb to 191.9kb) See screenshot below kindly ignore the first image it's the profile picture from the front camera.
Screenshot 2023-04-24 at 18 48 41
A possible cause might be the image capture size already been specified in the Camera.kt file this feature might not be able to override that. Also might be this PR isn't yet forcing the size of images.

@Elforama
Copy link
Contributor Author

This doesn't force the size yet. It just adds the dev screen

@EngrTaofeek
Copy link
Collaborator

Oh if that's the case it's all good just a few UI changes and addition . The bottom left arrow button, a header for the screen and the checked state color of the checkbox should be the primary colour(green) instead of blue.

@Elforama Elforama merged commit f59fa8e into master Apr 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants