Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contract endpoint and queries #307

Merged
merged 6 commits into from
Nov 13, 2023
Merged

Conversation

gwynndp
Copy link
Collaborator

@gwynndp gwynndp commented Apr 21, 2023

Add endpoint and queries to support contract tool

@gwynndp
Copy link
Collaborator Author

gwynndp commented Apr 21, 2023

@Kpoke Please review when you have a chance!

server/interfaces/ContractFilter.ts Outdated Show resolved Hide resolved
server/infra/database/ContractRepository.ts Outdated Show resolved Hide resolved
@dadiorchen
Copy link
Contributor

@gwynndp @Kpoke I'm thinking if we put more and more query API crossing schema into this repo, there might be some impact on the domain design, that supposed to be based on microservices?

@Kpoke
Copy link
Collaborator

Kpoke commented May 4, 2023

It depends, if all information needed can be gotten from the contract API alone then that is fine, but if cross-schema joins are needed then we would have to use the query API.

@gwynndp gwynndp requested a review from Kpoke November 10, 2023 21:27
@gwynndp
Copy link
Collaborator Author

gwynndp commented Nov 12, 2023

@Kpoke @dadiorchen Do we have documentation of all the apps using these services and what data they need?

@Kpoke
Copy link
Collaborator

Kpoke commented Nov 13, 2023

Do you mean the query API or the contract service? For the contract service just the admin panel for now, for the query API , I believe it is just the admin panel/web map

@Kpoke Kpoke merged commit ccb03c5 into Greenstand:main Nov 13, 2023
1 check passed
Copy link

🎉 This PR is included in version 1.71.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants