Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Change the bounds format to follow google map #1715

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

QuanGiap
Copy link
Contributor

@QuanGiap QuanGiap commented Sep 9, 2023

Description

Change the URL coordinate to follow the Google format map.
Fixes #658

Type of change

  • New feature (non-breaking change which adds functionality)

Video

In this video, first you can see the coordinate URL will be changed from ".../?bounds=,,," to "../?view=,,z". The website will still work if the link contains bounds

screen-capture.1.webm

How Has This Been Tested?

  • Cypress integration
  • Cypress component tests
  • Jest unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@QuanGiap QuanGiap marked this pull request as draft September 9, 2023 22:57
@QuanGiap QuanGiap marked this pull request as ready for review September 9, 2023 22:58
@QuanGiap QuanGiap closed this Sep 9, 2023
@QuanGiap QuanGiap reopened this Sep 9, 2023
@dadiorchen
Copy link
Collaborator

@sebastiangaertner This is an overdue requirement that we want to use more better format to present the map view, take a look at the video, and please help us consider the impact of this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the bounds format to follow google map
2 participants