Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 1764 add timeline #1787

Draft
wants to merge 3 commits into
base: v2
Choose a base branch
from
Draft

V2 1764 add timeline #1787

wants to merge 3 commits into from

Conversation

ha0min
Copy link

@ha0min ha0min commented Jun 27, 2024

Description

This draft PR introduces the TreeCapturesTimeline component. It includes updates to make it responsive and adds endpoints and routes for retrieving tree captures. However, the component design is complete, but there are issues with mocking the capture page data that still need to be resolved.

Fixes #1764 (partially)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Before After
"screenshot before" image

How Has This Been Tested?

  • Cypress integration
  • Cypress component tests
  • Jest unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ha0min
Copy link
Author

ha0min commented Jun 27, 2024

Hi @dadiorchen, could you kindly review if the component looks good and provide guidance to how to mock the api for v2/capture page? currently I got stacked when the page request getStakeHolderById.

@ha0min ha0min mentioned this pull request Jun 27, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant