Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail WebSocket early #1525

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fail WebSocket early #1525

merged 1 commit into from
Mar 21, 2024

Conversation

danielcweber
Copy link
Contributor

No description provided.

@danielcweber danielcweber changed the base branch from 12.x to 7.x March 21, 2024 09:35
@danielcweber danielcweber changed the base branch from 7.x to 12.x March 21, 2024 09:35
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.41%. Comparing base (36468fa) to head (31f8fe2).

Files Patch % Lines
...ers.Core/Factory/WebSocketGremlinqClientFactory.cs 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             12.x    #1525      +/-   ##
==========================================
- Coverage   79.46%   79.41%   -0.06%     
==========================================
  Files         252      252              
  Lines        6970     6972       +2     
  Branches     1660     1661       +1     
==========================================
- Hits         5539     5537       -2     
- Misses        633      639       +6     
+ Partials      798      796       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielcweber danielcweber merged commit 31f8fe2 into 12.x Mar 21, 2024
2 of 4 checks passed
@danielcweber danielcweber deleted the FailWebSocketEarly branch March 21, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant