Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: export metrics #762

Closed

Conversation

Taylor-lagrange
Copy link
Contributor

What's Changed in this PR

relevant pr

GreptimeTeam/greptimedb#2928
GreptimeTeam/greptimedb#3047

Checklist

  • Please ensure that the content in summary.yml matches the current document structure when you changed the document structure.
  • This change requires follow-up update in localized docs.

Closes #724
Closes #760

@Taylor-lagrange Taylor-lagrange requested review from nicecui and a team as code owners January 4, 2024 08:42
Copy link
Collaborator

@nicecui nicecui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The audience of the doc is users, just like we talk to users through the docs, so we need to use you instead of users as the subject in the operation introductions.

docs/v0.5/en/user-guide/operations/configuration.md Outdated Show resolved Hide resolved
docs/v0.5/en/user-guide/operations/configuration.md Outdated Show resolved Hide resolved
docs/v0.5/en/user-guide/operations/configuration.md Outdated Show resolved Hide resolved
@nicecui
Copy link
Collaborator

nicecui commented Jan 24, 2024

merged via #790

@nicecui nicecui closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants