Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support export metric in remote write format #2928

Merged
merged 4 commits into from Dec 22, 2023
Merged

feat: Support export metric in remote write format #2928

merged 4 commits into from Dec 22, 2023

Conversation

Taylor-lagrange
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Support export metric in remote write format

Add configuration logging.remote_write, user can use it collect the metrics generated by db periodically and send it to Prometheus remote-write compatible receiver (e.g. greptimedb)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023 •
edited

Codecov Report

Attention: 113 lines in your changes are missing coverage. Please review.

Comparison is base (839e653) 85.76% compared to head (308c5fb) 85.37%.
Report is 12 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2928      +/-   ##
===========================================
- Coverage    85.76%   85.37%   -0.39%     
===========================================
  Files          767      780      +13     
  Lines       123627   125864    +2237     
===========================================
+ Hits        106026   107455    +1429     
- Misses       17601    18409     +808

waynexia
waynexia reviewed Dec 15, 2023
View reviewed changes
config/standalone.example.toml Outdated Show resolved Hide resolved
src/common/telemetry/src/metric.rs Outdated Show resolved Hide resolved
waynexia
waynexia reviewed Dec 18, 2023
View reviewed changes
src/common/telemetry/src/logging.rs Outdated Show resolved Hide resolved
src/common/telemetry/src/metric.rs Outdated Show resolved Hide resolved
zhongzc
zhongzc reviewed Dec 19, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
zhongzc
zhongzc approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@zhongzc zhongzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now!

waynexia
waynexia reviewed Dec 20, 2023
View reviewed changes
config/standalone.example.toml Outdated Show resolved Hide resolved
config/standalone.example.toml Outdated Show resolved Hide resolved
config/standalone.example.toml Outdated Show resolved Hide resolved
src/common/telemetry/src/metric.rs Outdated Show resolved Hide resolved
waynexia
waynexia reviewed Dec 21, 2023
View reviewed changes
config/datanode.example.toml Show resolved Hide resolved
src/servers/src/error.rs Outdated Show resolved Hide resolved
src/meta-srv/src/error.rs Outdated Show resolved Hide resolved
killme2008
killme2008 reviewed Dec 21, 2023
View reviewed changes
config/datanode.example.toml Outdated Show resolved Hide resolved
config/datanode.example.toml Outdated Show resolved Hide resolved
config/datanode.example.toml Outdated Show resolved Hide resolved
config/datanode.example.toml Outdated Show resolved Hide resolved
config/datanode.example.toml Outdated Show resolved Hide resolved
src/cmd/src/frontend.rs Outdated Show resolved Hide resolved
src/datanode/src/datanode.rs Outdated Show resolved Hide resolved
src/servers/src/system_metric.rs Outdated Show resolved Hide resolved
src/servers/src/system_metric.rs Outdated Show resolved Hide resolved
src/servers/src/system_metric.rs Outdated Show resolved Hide resolved
@waynexia waynexia mentioned this pull request Dec 21, 2023
Open
killme2008
killme2008 approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job!

@killme2008 killme2008 added this pull request to the merge queue Dec 22, 2023
Merged via the queue into GreptimeTeam:develop with commit 675767c Dec 22, 2023
19 checks passed
This was referenced Dec 22, 2023
Closed
Closed
@killme2008 killme2008 added the docs-required This change requires docs update. label Dec 22, 2023
@sunng87 sunng87 mentioned this pull request Dec 22, 2023
Closed
@killme2008 killme2008 added A-observability Involves code in the telemetry path cloud followup required labels Dec 22, 2023
@Taylor-lagrange Taylor-lagrange deleted the feat-metric-table branch December 25, 2023 02:03
This was referenced Dec 29, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia left review comments

@zhongzc zhongzc zhongzc approved these changes

@killme2008 killme2008 killme2008 approved these changes

@shuiyisong shuiyisong Awaiting requested review from shuiyisong

Assignees
No one assigned
Labels
A-observability Involves code in the telemetry path docs-required This change requires docs update.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Taylor-lagrange @killme2008 @waynexia @zhongzc @shuiyisong