chore: apply suggestions from CR

GreptimeTeam · Jul 12, 2024 · 640e462 · 640e462
1 parent 7dda31c
commit 640e462
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/meta-srv/src/election/etcd.rs b/src/meta-srv/src/election/etcd.rs
@@ -256,15 +256,18 @@ impl Election for EtcdElection {
                 }
             }
 
-            if self.is_leader.load(Ordering::Relaxed) {
+            if self
+                .is_leader
+                .compare_exchange(true, false, Ordering::Relaxed, Ordering::Relaxed)
+                .is_ok()
+            {
                 if let Err(e) = self
                     .leader_watcher
                     .send(LeaderChangeMessage::StepDown(Arc::new(leader.clone())))
                 {
                     error!(e; "Failed to send leader change message");
                 }
             }
-            self.is_leader.store(false, Ordering::Relaxed);
         }
 
         Ok(())