Check if ports are occupied before start sqlness test

[waynexia]

What problem does the new feature solve?

Sqlness uses the common port (e.g. 4000) to start server. It's common that the port is occupied by other process like another greptimedb process. In this case the test result will become weird because it's actually testing something else

What does the feature do?

Check those ports before spawn subprocess. Sqlness only check if the port is up after spawn at present.

Implementation challenges

No response

[Gump9]

I'm a little confused about

Check those ports before spawn subprocess.

it that means Sqlness will spawn subprocess?

Which file can give me a first look at the problem？

Sqlness only check if the port is up after spawn at present.

[Gump9]

Sry,i don't see it has been assigned😭

[WenyXu]

Sry,i don't see it has been assigned😭

Never mind. We got a ton of the good first issues waiting for you 🤪

[evenyag]

@Gump9 Are you still interested in this issue? Feel free to take it.

[Gump9]

@Gump9 Are you still interested in this issue? Feel free to take it.

Yes,can I have a try?tks alot

[Gump9]

and i still want to know more details about this issue i mentioned above

[waynexia]

it that means Sqlness will spawn subprocess?

Which file can give me a first look at the problem？

Yes, sqlness runner will start greptimedb (metasrv/frontend/datanode) to test. You can check it out here

greptimedb/tests/runner/src/env.rs

Line 124 in fcff66e

async fn start_server(

[Gump9]

@waynexia thx a lot😄

[Gump9]

@waynexia Hi!should i just panic like the code below？because i found "Sqlness only check if the port is up after spawn at present." do something like this:

if !util::check_port(check_ip_addr.parse().unwrap(), Duration::from_secs(10)).await {
            Env::stop_server(&mut process);
            panic!("{subcommand} doesn't up in 10 seconds, quit.")
}

or,should i choose another port and try to up a process again?

[waynexia]

panic should be enough. We can add one config entry for port later

[Gump9]

panic should be enough. We can add one config entry for port later

thx!