Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add check port before start sqlness test #1895

Merged
merged 6 commits into from Jul 12, 2023

Conversation

Gump9
Copy link
Contributor

@Gump9 Gump9 commented Jul 6, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

add check port before start sqlness test

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#1602

tests/runner/src/env.rs Outdated Show resolved Hide resolved
@v0y4g3r
Copy link
Contributor

v0y4g3r commented Jul 6, 2023

Thanks! Please fix the format issue by running cargo fmt --all and I'm ok to approve it.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1895 (89ff9b7) into develop (783a794) will decrease coverage by 0.57%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1895      +/-   ##
===========================================
- Coverage    86.47%   85.91%   -0.57%     
===========================================
  Files          589      614      +25     
  Lines        95647    99346    +3699     
===========================================
+ Hits         82714    85351    +2637     
- Misses       12933    13995    +1062     

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gump9
Copy link
Contributor Author

Gump9 commented Jul 10, 2023

@waynexia Hi,I have removed the redundant check_port,but there are still somethings confused me,As we did in the second check_port,we use stop_server,i understand it as killing zombie process(although this check_port will never run),and my doubt is that if the spawn() return error,will it cause zombie process?if it is,should we handle the zombie process?and how to?😥

@waynexia
Copy link
Member

For the port unavailable case, our program will terminate by itself. We only need to check the result of Command to make sure the process is running rather than being terminated. For other cases we need to kill it by stop_server.

@Gump9
Copy link
Contributor Author

Gump9 commented Jul 10, 2023

For the port unavailable case, our program will terminate by itself. We only need to check the result of Command to make sure the process is running rather than being terminated. For other cases we need to kill it by stop_server.

thx!what can I do for this feat next?Is it done?😳

@waynexia waynexia enabled auto-merge (squash) July 11, 2023 02:53
@waynexia
Copy link
Member

test failed, can you fix it?

@Gump9
Copy link
Contributor Author

Gump9 commented Jul 11, 2023

test failed, can you fix it?

i will

auto-merge was automatically disabled July 12, 2023 02:57

Head branch was pushed to by a user without write access

@v0y4g3r v0y4g3r merged commit 2bfe251 into GreptimeTeam:develop Jul 12, 2023
11 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat:add check port before start sqlness test

* cr comment

* feat:remove redundant check_port

* cr comment

* cr comment

* cr comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants