New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:add check port before start sqlness test #1895
Conversation
Thanks! Please fix the format issue by running |
Codecov Report
@@ Coverage Diff @@
## develop #1895 +/- ##
===========================================
- Coverage 86.47% 85.91% -0.57%
===========================================
Files 589 614 +25
Lines 95647 99346 +3699
===========================================
+ Hits 82714 85351 +2637
- Misses 12933 13995 +1062 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@waynexia Hi,I have removed the redundant |
For the port unavailable case, our program will terminate by itself. We only need to check the result of |
thx!what can I do for this feat next?Is it done?😳 |
test failed, can you fix it? |
i will |
Head branch was pushed to by a user without write access
* feat:add check port before start sqlness test * cr comment * feat:remove redundant check_port * cr comment * cr comment * cr comment
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
add check port before start sqlness test
Checklist
Refer to a related PR or issue link (optional)
#1602