-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement promql query on grpc #1134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunng87
force-pushed
the
feature/grpc-promql
branch
from
March 7, 2023 10:08
c2c21fa
to
aac92bc
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1134 +/- ##
==========================================
Coverage ? 85.13%
==========================================
Files ? 482
Lines ? 71290
Branches ? 0
==========================================
Hits ? 60695
Misses ? 10595
Partials ? 0 |
killme2008
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MichaelScofield
approved these changes
Mar 13, 2023
yuanbohan
approved these changes
Mar 13, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: implement promql query on grpc * test: resolve test errors * test: add tests for promql grpc api * refactor: align prom object name with proto * chore: switch proto revision to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This patch adds promql support for grpc service. This patch is based on a commit on GreptimeTeam/greptime-proto#13, please merge the proto before this.
Checklist
Refer to a related PR or issue link (optional)
close #936