Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement promql query on grpc #1134

Merged
merged 5 commits into from
Mar 13, 2023
Merged

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Mar 7, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This patch adds promql support for grpc service. This patch is based on a commit on GreptimeTeam/greptime-proto#13, please merge the proto before this.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

close #936

@sunng87 sunng87 linked an issue Mar 9, 2023 that may be closed by this pull request
@waynexia waynexia self-requested a review March 9, 2023 05:52
@sunng87 sunng87 marked this pull request as ready for review March 9, 2023 08:09
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@b70672b). Click here to learn what that means.
The diff coverage is 78.62%.

@@            Coverage Diff             @@
##             develop    #1134   +/-   ##
==========================================
  Coverage           ?   85.13%           
==========================================
  Files              ?      482           
  Lines              ?    71290           
  Branches           ?        0           
==========================================
  Hits               ?    60695           
  Misses             ?    10595           
  Partials           ?        0           

@sunng87
Copy link
Member Author

sunng87 commented Mar 13, 2023

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield merged commit 85dd7e4 into develop Mar 13, 2023
@MichaelScofield MichaelScofield deleted the feature/grpc-promql branch March 13, 2023 07:24
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* feat: implement promql query on grpc

* test: resolve test errors

* test: add tests for promql grpc api

* refactor: align prom object name with proto

* chore: switch proto revision to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support promql query in grpc interface
4 participants