fix: dn doesn't have chance to send a heartbeat to the new leader #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2471 +/- ##
===========================================
- Coverage 84.88% 84.50% -0.38%
===========================================
Files 725 725
Lines 115186 115212 +26
===========================================
- Hits 97780 97365 -415
- Misses 17406 17847 +441 |
WenyXu
changed the title
MichaelScofield
approved these changes
Sep 26, 2023
Merged
via the queue into
GreptimeTeam:develop
with commit Sep 26, 2023
230a302
32 of 33 checks passed
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…eptimeTeam#2471) * refactor: set meta leader lease secs to 3s * fix: correct default heartbeat interval * refactor: ask meta leader in parallel * feat: configure heartbeat client timeout to 500ms * fix: trigger to send heartbeat immediately after fail * fix: fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
If the metasrv leader is dead, the datanode only has a small window(
Datanode Lease - (<Heartbeat interval + Timeout> + <Meta Lease> + <Ask Leader Timeout + Connect Timeout>) to resend region stats. We must ensure the small window is greater than 0s. After this PR, the datanode will have a 5.5s~ (13s - 3.5s - 3s - 1s) window to resend the heartbeat.Checklist
Refer to a related PR or issue link (optional)