Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace InactiveRegionManager with RegionLeaseKeeper #2729

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Nov 10, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Replace InactiveRegionManager with RegionLeaseKeeper
  2. Remove InactiveRegionManager

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2700
close #2636

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2729 (f0072f2) into develop (22ee45f) will decrease coverage by 85.24%.
Report is 5 commits behind head on develop.
The diff coverage is n/a.

❗ Current head f0072f2 differs from pull request most recent head 1be73d8. Consider uploading reports for the commit 1be73d8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #2729       +/-   ##
===========================================
- Coverage    85.23%       0   -85.24%     
===========================================
  Files          765       0      -765     
  Lines       124178       0   -124178     
===========================================
- Hits        105842       0   -105842     
+ Misses       18336       0    -18336     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue Nov 14, 2023
Merged via the queue into GreptimeTeam:develop with commit dc46e96 Nov 14, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove InactiveRegionManager
3 participants