Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos and bit operations #2944

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Conversation

QuenKar
Copy link
Contributor

@QuenKar QuenKar commented Dec 18, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

changes:

  • interval typos.
  • fix decimal128 and interval bit operations.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Cargo.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #2944 (58d83ec) into develop (e35a494) will decrease coverage by 0.49%.
The diff coverage is 82.22%.

❗ Current head 58d83ec differs from pull request most recent head 29a672a. Consider uploading reports for the commit 29a672a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2944      +/-   ##
===========================================
- Coverage    85.05%   84.57%   -0.49%     
===========================================
  Files          754      754              
  Lines       119742   119784      +42     
===========================================
- Hits        101847   101303     -544     
- Misses       17895    18481     +586     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuenKar QuenKar requested a review from WenyXu December 18, 2023 03:02
@waynexia waynexia added this pull request to the merge queue Dec 18, 2023
Merged via the queue into GreptimeTeam:develop with commit 5dc7ce1 Dec 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants