Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge tree dedup reader #3375

Merged
merged 7 commits into from Feb 24, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Feb 24, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR:

  • adds dedup config to Shard/ShardBuilder/DataBuffer etc. to control whether rows with duplicate ts should be removed
  • impls DedupReader so that we can remove duplicated rows among different data batches.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@v0y4g3r v0y4g3r marked this pull request as ready for review February 24, 2024 12:38
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 24, 2024
@v0y4g3r v0y4g3r requested a review from evenyag February 24, 2024 12:39
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 89.03654% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 85.18%. Comparing base (1df64f2) to head (7752a11).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3375      +/-   ##
==========================================
- Coverage   85.59%   85.18%   -0.41%     
==========================================
  Files         892      893       +1     
  Lines      146564   146815     +251     
==========================================
- Hits       125448   125070     -378     
- Misses      21116    21745     +629     

src/mito2/src/memtable/merge_tree/data.rs Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/dedup.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/dedup.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/dedup.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Feb 24, 2024
Merged via the queue into GreptimeTeam:main with commit afe4633 Feb 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants