New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): remove some unused dependencies #3582
Conversation
Most of the unused deps you removed in this patch are still dependent in other places so the overall compile time doesn't change a lot. But still appreciate it 💯 |
Only test |
Have you tried the mold? It only takes ~4GiB memory for |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3582 +/- ##
==========================================
- Coverage 85.25% 84.90% -0.35%
==========================================
Files 917 917
Lines 152869 152892 +23
==========================================
- Hits 130324 129818 -506
- Misses 22545 23074 +529 |
Test it and time reduces from What do you mean |
@waynexia it can be a subtask of a revision of CONTRIBUTING.md. You can create an issue and ping me. I schedule to handle the CONTRIBUTING.md file in April; any feedback is welcome :D |
Ticket: #3587 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then let's go?
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
It takes quite long time to build the project on my laptop, so I tried to remove
some dependencies to see whether it will improve the compile time.
From my local test with
cargo build --timings
aftercargo clean
the cachebefore:
after:
However, I only observed very little improvement except units reduce from 1229
to 1219. The compilation will drain all my memory and sometimes crash my GUI,
so maybe better hardware can give more improvements?
Checklist