Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: limit OpenDAL's feature gates #3584

Merged
merged 1 commit into from Mar 26, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Mar 26, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Topic from #3582

What's changed and what's your intention?

OpenDAL's default features contain many services that aren't used in our system. Opt them out can reduce the compile time of OpenDAL by half (from 29.31s to 15.07s) and speed up the overall compile time by 2s (out of 151s in total).

This is because OpenDAL lies in the critical path of the entire compile progress, and long compile time would lead to a small hang:

- -
Before image
After image

P.S.:

The following big hang is from DataFusion...

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 26, 2024
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.89%. Comparing base (7c1c6e8) to head (43bed48).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3584      +/-   ##
==========================================
- Coverage   85.25%   84.89%   -0.37%     
==========================================
  Files         917      924       +7     
  Lines      152892   153487     +595     
==========================================
- Hits       130344   130296      -48     
- Misses      22548    23191     +643     

@shuiyisong shuiyisong added this pull request to the merge queue Mar 26, 2024
Merged via the queue into GreptimeTeam:main with commit 83c1b48 Mar 26, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants