New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: construct correct pk list with pre-existing pk #3614
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
CI failure fix: #3616 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works on my branch🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@waynexia There is a test failure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3614 +/- ##
==========================================
- Coverage 85.43% 84.84% -0.59%
==========================================
Files 932 943 +11
Lines 155190 157092 +1902
==========================================
+ Hits 132588 133291 +703
- Misses 22602 23801 +1199 |
* fix: construct correct pk list with pre-existing pk Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * update UT Signed-off-by: Ruihang Xia <waynestxia@gmail.com> --------- Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
* fix: columns table in information_schema misses some columns * fix: test_information_schema_dot_columns * fix: fuzz test * feat: adds srs_id and refactor some columns with constant vector * fix: test_information_schema_dot_columns * chore: update comment Co-authored-by: JeremyHi <jiachun_feng@proton.me> * build(deps): bump h2 from 0.3.24 to 0.3.26 (#3642) Bumps [h2](https://github.com/hyperium/h2) from 0.3.24 to 0.3.26. - [Release notes](https://github.com/hyperium/h2/releases) - [Changelog](https://github.com/hyperium/h2/blob/v0.3.26/CHANGELOG.md) - [Commits](hyperium/h2@v0.3.24...v0.3.26) --- updated-dependencies: - dependency-name: h2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump whoami from 1.4.1 to 1.5.1 (#3643) Bumps [whoami](https://github.com/ardaku/whoami) from 1.4.1 to 1.5.1. - [Changelog](https://github.com/ardaku/whoami/blob/v1/CHANGELOG.md) - [Commits](ardaku/whoami@v1.4.1...v1.5.1) --- updated-dependencies: - dependency-name: whoami dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: adding victoriametrics remote write (#3641) * feat: adding victoria metrics remote write * test: add e2e tests for prom and vm remote writes * fix: construct correct pk list with pre-existing pk (#3614) * fix: construct correct pk list with pre-existing pk Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * update UT Signed-off-by: Ruihang Xia <waynestxia@gmail.com> --------- Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * test(sqlness): release databases after tests (#3648) * refactor: rename Greptime_Type to Greptime_type --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ruihang Xia <waynestxia@gmail.com> Co-authored-by: JeremyHi <jiachun_feng@proton.me> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ning Sun <sunng@protonmail.com> Co-authored-by: Ruihang Xia <waynestxia@gmail.com> Co-authored-by: Weny Xu <wenymedia@gmail.com>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
Closes #3612
What's changed and what's your intention?
The previous test doesn't cover creating physical table with some primary keys
Checklist