Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ignore type in sqlness sql and result files #3616

Merged
merged 1 commit into from Mar 29, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

False positive:
https://github.com/GreptimeTeam/greptimedb/actions/runs/8479383890/job/23233296359?pr=3614

Test SQL may contain arbitrary words.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 29, 2024
@waynexia waynexia enabled auto-merge March 29, 2024 09:27
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.08%. Comparing base (500f9f1) to head (92c7aff).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3616      +/-   ##
==========================================
- Coverage   85.43%   85.08%   -0.36%     
==========================================
  Files         932      932              
  Lines      155190   155190              
==========================================
- Hits       132592   132045     -547     
- Misses      22598    23145     +547     

Merged via the queue into GreptimeTeam:main with commit 7a19f66 Mar 29, 2024
19 checks passed
@waynexia waynexia deleted the ignore-sqlness-typo branch March 29, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants