Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logs for setting the region to writable #4044

Merged
merged 2 commits into from
May 27, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 26, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

add logs for setting the region to writable

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 26, 2024
Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.13%. Comparing base (5df3d4e) to head (4a3376c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4044      +/-   ##
==========================================
- Coverage   85.42%   85.13%   -0.30%     
==========================================
  Files         983      983              
  Lines      170493   170510      +17     
==========================================
- Hits       145652   145158     -494     
- Misses      24841    25352     +511     

src/mito2/src/region.rs Outdated Show resolved Hide resolved
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu enabled auto-merge May 27, 2024 03:48
@WenyXu WenyXu added this pull request to the merge queue May 27, 2024
Merged via the queue into GreptimeTeam:main with commit 389ded9 May 27, 2024
28 checks passed
@WenyXu WenyXu deleted the chore/add-logs branch May 27, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants