Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add num_rows and num_row_groups to manifest #4183

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Add num_rows and num_row_groups to mito manifest.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added breaking-change This pull request contains breaking changes. docs-not-required This change does not impact docs. labels Jun 20, 2024
@waynexia waynexia changed the title feat!: add num_rows and num_row_groups to manifest feat: add num_rows and num_row_groups to manifest Jun 20, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.79%. Comparing base (5bcd7a1) to head (9126c9c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4183      +/-   ##
==========================================
- Coverage   85.10%   84.79%   -0.31%     
==========================================
  Files        1022     1022              
  Lines      179849   179906      +57     
==========================================
- Hits       153059   152555     -504     
- Misses      26790    27351     +561     

@waynexia waynexia removed the breaking-change This pull request contains breaking changes. label Jun 20, 2024
@waynexia waynexia added this pull request to the merge queue Jun 21, 2024
Merged via the queue into GreptimeTeam:main with commit ac574b6 Jun 21, 2024
49 checks passed
@waynexia waynexia deleted the extend-manifest branch June 21, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants