-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: LastRowReader to use LastRowSelector #4374
Conversation
- Replaced `last_batch` in `LastRowReader` with `LastRowSelector`.
Note Reviews pausedUse the following commands to manage reviews:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@coderabbitai pause |
Actions performedReviews paused. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4374 +/- ##
==========================================
- Coverage 85.15% 84.88% -0.28%
==========================================
Files 1074 1074
Lines 191831 191836 +5
==========================================
- Hits 163360 162835 -525
- Misses 28471 29001 +530 |
last_batch
inLastRowReader
withLastRowSelector
.I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Extracts the last row selection logic to a common struct.
Checklist