Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement postgres kvbackend #4421

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

lyang24
Copy link
Contributor

@lyang24 lyang24 commented Jul 24, 2024

This commit implement a postgres backend to persist metasrv's data. A new enum BackendImpl with default to etcd was added to MetasrvOptions to activate postgres backend we could set BackendImpl to postgres and set store_addrs to postgres url.

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

!!! DO NOT LEAVE THIS BLOCK EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Copy link
Contributor

coderabbitai bot commented Jul 24, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jul 24, 2024
@lyang24 lyang24 changed the title (wip) feat: implement kvs postgres backend (wip) feat: implement postgres kvbackend Jul 24, 2024
@lyang24 lyang24 mentioned this pull request Jul 24, 2024
2 tasks
@lyang24 lyang24 force-pushed the postgres_kv_backend branch 5 times, most recently from 883ac2d to 4c2c67f Compare July 31, 2024 23:55
@lyang24 lyang24 changed the title (wip) feat: implement postgres kvbackend feat: implement postgres kvbackend Aug 2, 2024
@lyang24 lyang24 force-pushed the postgres_kv_backend branch 2 times, most recently from e264178 to ca35aa2 Compare August 2, 2024 04:15
@lyang24 lyang24 marked this pull request as ready for review August 2, 2024 04:16
@lyang24 lyang24 requested review from MichaelScofield and a team as code owners August 2, 2024 04:16
@killme2008
Copy link
Contributor

@lyang24 Hi, there are some CI failures, could you check them?

@lyang24 lyang24 marked this pull request as draft August 2, 2024 18:00
@lyang24 lyang24 changed the title feat: implement postgres kvbackend (wip) feat: implement postgres kvbackend Aug 2, 2024
@lyang24 lyang24 changed the title (wip) feat: implement postgres kvbackend feat: implement postgres kvbackend Aug 3, 2024
@lyang24
Copy link
Contributor Author

lyang24 commented Aug 3, 2024

@lyang24 Hi, there are some CI failures, could you check them?

Yes, ci is green now

@lyang24 lyang24 marked this pull request as ready for review August 3, 2024 03:07
@lyang24 lyang24 marked this pull request as draft August 3, 2024 20:57
@killme2008
Copy link
Contributor

@lyang24 Is it ready to review? If it is, I'd like to do it.

@lyang24 lyang24 force-pushed the postgres_kv_backend branch 4 times, most recently from 98c9df7 to 8b1c4d4 Compare August 12, 2024 05:15
@lyang24 lyang24 changed the title (wip) feat: implement postgres kvbackend feat: implement postgres kvbackend Aug 12, 2024
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM.

src/common/meta/src/kv_backend/postgres.rs Show resolved Hide resolved
src/common/meta/src/kv_backend/postgres.rs Outdated Show resolved Hide resolved
src/common/meta/src/kv_backend/postgres.rs Show resolved Hide resolved
src/cmd/src/metasrv.rs Show resolved Hide resolved
src/common/meta/Cargo.toml Outdated Show resolved Hide resolved
src/common/meta/Cargo.toml Outdated Show resolved Hide resolved
src/meta-srv/Cargo.toml Outdated Show resolved Hide resolved
src/common/meta/src/error.rs Outdated Show resolved Hide resolved
src/meta-srv/src/error.rs Outdated Show resolved Hide resolved
src/meta-srv/src/bootstrap.rs Show resolved Hide resolved
src/common/meta/src/error.rs Outdated Show resolved Hide resolved
src/common/meta/src/kv_backend/postgres.rs Outdated Show resolved Hide resolved
src/common/meta/src/kv_backend/postgres.rs Show resolved Hide resolved
@lyang24 lyang24 force-pushed the postgres_kv_backend branch 7 times, most recently from 1aafeaa to 8d8334a Compare August 13, 2024 17:57
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/meta-srv/Cargo.toml Show resolved Hide resolved
src/common/meta/src/kv_backend/postgres.rs Show resolved Hide resolved
@killme2008
Copy link
Contributor

@lyang24 Thanks a lot. It's a great work!

@killme2008 killme2008 added this pull request to the merge queue Aug 14, 2024
@killme2008
Copy link
Contributor

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 14, 2024
@killme2008 killme2008 added this pull request to the merge queue Aug 14, 2024
Merged via the queue into GreptimeTeam:main with commit 93be81c Aug 14, 2024
32 checks passed
@lyang24
Copy link
Contributor Author

lyang24 commented Aug 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants