Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add scale support for meta #146

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Aug 31, 2023

Closes: #96

initially planning to implement update (which is scale cmd) for bare-metal in this PR, but found this is unnecessary and troublesome.

for now bare-metal runs in foreground, which is easy to just close, modify configs and start, rather than open another cmd to launch the restart signal.

Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from zyy17 August 31, 2023 03:46
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.05% 🎉

Comparison is base (05d9130) 31.81% compared to head (8055665) 31.86%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #146      +/-   ##
===========================================
+ Coverage    31.81%   31.86%   +0.05%     
===========================================
  Files            9        9              
  Lines         1292     1293       +1     
===========================================
+ Hits           411      412       +1     
  Misses         787      787              
  Partials        94       94              
Files Changed Coverage Δ
pkg/cmd/gtctl/cluster/get/get.go 10.00% <0.00%> (ø)
pkg/deployer/baremetal/deployer.go 35.16% <100.00%> (+0.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyy17 zyy17 merged commit 7078dae into GreptimeTeam:develop Sep 1, 2023
6 checks passed
@shawnh2 shawnh2 deleted the update-cmd-4bm branch September 1, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully CRUD support for greptimedb cluster in bare-metal mode
3 participants