Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: include noscript installation #191

Merged
merged 2 commits into from
Feb 27, 2024
Merged

docs: include noscript installation #191

merged 2 commits into from
Feb 27, 2024

Conversation

tisonkun
Copy link
Contributor

go install is trustworthy.

More and more users would doubt if an install script from the Internet is safe ..

@tisonkun tisonkun requested a review from zyy17 February 20, 2024 17:31
@zyy17
Copy link
Collaborator

zyy17 commented Feb 21, 2024

@tisonkun I'm not sure go install will be a better idea because the installation will build and install the project, so this operation may not be more convenient than installing from the script(just download the pre-built binary by the given source and version). I understand why users don't trust scripts from the Internet because the script could "do" some bad things even if the project is open source.

@tisonkun
Copy link
Contributor Author

@zyy17 fair enough. What about we switch the order? Explain how to install without go install for those who concerned with Internet script an exit gate.

@zyy17
Copy link
Collaborator

zyy17 commented Feb 22, 2024

@zyy17 fair enough. What about we switch the order? Explain how to install without go install for those who concerned with Internet script an exit gate.

Look good to me.

@tisonkun
Copy link
Contributor Author

@zyy17 Sorry I miss this reply. Patch updated.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.76%. Comparing base (117cbfb) to head (49c2b85).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #191   +/-   ##
========================================
  Coverage    37.76%   37.76%           
========================================
  Files           16       16           
  Lines         1300     1300           
========================================
  Hits           491      491           
  Misses         704      704           
  Partials       105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tisonkun tisonkun changed the title docs: recommend noscript installation docs: include noscript installation Feb 26, 2024
@zyy17 zyy17 merged commit 038c2b8 into develop Feb 27, 2024
11 checks passed
@zyy17 zyy17 deleted the tisonkun-patch-1 branch February 27, 2024 03:10
MichaelScofield pushed a commit to MichaelScofield/gtctl that referenced this pull request Feb 27, 2024
* docs: recommend noscript installation

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants