Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump actions version #198

Merged
merged 2 commits into from
Mar 26, 2024
Merged

ci: bump actions version #198

merged 2 commits into from
Mar 26, 2024

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Mar 26, 2024

Before add a Dockerfile build, I'd like to make the CI workflows tidy ..

Signed-off-by: tison <wander4096@gmail.com>
@daviderli614
Copy link
Member

daviderli614 commented Mar 26, 2024

@tisonkun
Copy link
Contributor Author

Yes. It's about empty secret that we don't set yet. I'm consulting our org admin for suggestions.

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.96%. Comparing base (6e4058c) to head (6f6d479).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #198      +/-   ##
===========================================
+ Coverage    37.76%   40.96%   +3.19%     
===========================================
  Files           16       16              
  Lines         1300      991     -309     
===========================================
- Hits           491      406      -85     
+ Misses         704      480     -224     
  Partials       105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tisonkun
Copy link
Contributor Author

@daviderli614 fixed. PTAL

Copy link
Member

@daviderli614 daviderli614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daviderli614 daviderli614 merged commit 9c7c9fa into develop Mar 26, 2024
10 checks passed
@daviderli614 daviderli614 deleted the dockerimage branch March 26, 2024 07:56
MichaelScofield pushed a commit to MichaelScofield/gtctl that referenced this pull request Apr 28, 2024
* ci: bump actions version

Signed-off-by: tison <wander4096@gmail.com>

* Update .github/workflows/ci.yaml

---------

Signed-off-by: tison <wander4096@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants