-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bump actions version #198
Conversation
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun Can we fix the CI failing checks: https://github.com/GreptimeTeam/gtctl/actions/runs/8429980751/job/23085136468?pr=198 |
Yes. It's about empty secret that we don't set yet. I'm consulting our org admin for suggestions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #198 +/- ##
===========================================
+ Coverage 37.76% 40.96% +3.19%
===========================================
Files 16 16
Lines 1300 991 -309
===========================================
- Hits 491 406 -85
+ Misses 704 480 -224
Partials 105 105 ☔ View full report in Codecov by Sentry. |
@daviderli614 fixed. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* ci: bump actions version Signed-off-by: tison <wander4096@gmail.com> * Update .github/workflows/ci.yaml --------- Signed-off-by: tison <wander4096@gmail.com>
Before add a Dockerfile build, I'd like to make the CI workflows tidy ..