Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove opentsdb addr #203

Merged
merged 5 commits into from
May 22, 2024
Merged

Conversation

confoc
Copy link
Contributor

@confoc confoc commented May 22, 2024

In the new version, OpentsdbAddr is not used.
So,I delete the OpentsdbAddr in order to run gtctl correctly

@zyy17 zyy17 requested review from daviderli614 and zyy17 May 22, 2024 07:25
@daviderli614
Copy link
Member

@zyy17
Copy link
Collaborator

zyy17 commented May 22, 2024

@daviderli614 After the PR is merged, we need to release the new version.

@confoc confoc changed the title fix:delect OpentsdbAddr fix:delete OpentsdbAddr May 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.01%. Comparing base (9c7c9fa) to head (a893265).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #203      +/-   ##
===========================================
+ Coverage    40.96%   41.01%   +0.04%     
===========================================
  Files           16       16              
  Lines          991      990       -1     
===========================================
  Hits           406      406              
+ Misses         480      479       -1     
  Partials       105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daviderli614 daviderli614 changed the title fix:delete OpentsdbAddr chore: remove opentsdb addr May 22, 2024
Copy link
Member

@daviderli614 daviderli614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first PR in Greptime🎉

@zyy17 zyy17 merged commit efa2f7d into GreptimeTeam:develop May 22, 2024
7 checks passed
confoc added a commit to confoc/gtctl that referenced this pull request May 23, 2024
@confoc confoc deleted the fix-issue-201 branch May 28, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants