Merge layout shapes #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brean
commented
Feb 26, 2017
•
brean
commented
- merge PIXI.layout and PIXI.shapes back into main project
- switch to floss from testem (same as PIXI - creates a nice HTML-coverage report)
- switch from gulp to webpack (makes the build process a lot easier)
…the coverage, just run 'npm run coverage'
Closed
| * @param jsonPath {Array} | ||
| */ | ||
| Theme.prototype.loadImage = function(jsonPath) { | ||
| Theme.prototype.addImage = function(jsonPath) { |
There was a problem hiding this comment.
what is the reason for renaming the function?
I would like to avoid unnecessarily breaking the API.
There was a problem hiding this comment.
I changed the name because this function now only adds the file to the loader and does not load it. You need to call load on the GOWN.loader/PIXI.loader manually after you added all your files (this changed in some PIXI 4-version ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.