Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DaCe StringLiteral introduced in v0.14 breaks gt4py origin mapping #927

Open
jdahm opened this issue Sep 1, 2022 · 3 comments
Open

DaCe StringLiteral introduced in v0.14 breaks gt4py origin mapping #927

jdahm opened this issue Sep 1, 2022 · 3 comments
Assignees
@jdahm
Labels
gt4py.cartesian Issues concerning the current version with support only for cartesian grids.
Projects
GridTools
Milestone
Christmas Cleanup...

Comments

@jdahm
Copy link
Contributor

jdahm commented Sep 1, 2022

The fact that StringLiterals do not have comparison methods breaks some gt4py tests.
This is fixed on the DaCe side in spcl/dace#1101 and once updated we should remove the workaround in gt4py.
@gridtoolsjenkins gridtoolsjenkins added this to Triage in GridTools Sep 1, 2022
@gronerl
Copy link
Contributor

gronerl commented Oct 19, 2022

Fixed in dace since
spcl/dace#1117
Which was included in dace v0.14.1
Proper fix on our hand would now be to bump the version.

@gronerl gronerl added the gt4py.cartesian Issues concerning the current version with support only for cartesian grids. label Oct 19, 2022
@gronerl gronerl added this to the v1.0 / Christmas Cleanup 2022 milestone Oct 19, 2022
@jdahm
Copy link
Contributor Author

jdahm commented Oct 20, 2022

This is fixed in #979 at https://github.com/GridTools/gt4py/pull/979/files#diff-b53cc971b37e2ab046898dd6e068b679c09056b1278235dc0d7e9ccb8eabc913L290-L294 It also updates the dependency.

@jdahm jdahm mentioned this issue Oct 20, 2022
Merged
@jdahm jdahm self-assigned this Oct 20, 2022
@jdahm
Copy link
Contributor Author

jdahm commented Oct 25, 2022 •
edited

For some reason on #979 we still need the hack in order to keep all the tests in tests/test_integration/test_dace_parsing.py passing, so I'll keep https://github.com/GridTools/gt4py/blob/master/src/gt4py/stencil_object.py#L293 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdahm jdahm

Labels
gt4py.cartesian Issues concerning the current version with support only for cartesian grids.
Projects
GridTools
  
Triage
Milestone
Christmas Cleanup 2022
Development

No branches or pull requests
2 participants
@jdahm @gronerl