-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove src/__init__.py and fix many errors #979
Conversation
Looks like there's a circular import problem now, how should we proceed with this? |
I committed the code and pushed after nearly a whole day of working out these issues, only to find out about it 😆 .
The circular dependency should be solved, or rather avoided, by moving to the next version of |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryTimed out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's impressive the amount of work you've done in this PR to fix all typings! It looks good to me, just a couple of very minor questions and suggestions, but I don't see anything blocking the merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to go.
bors try |
tryBuild succeeded: |
Description
Major changes:
Expr.dtype
's type is no longerOptional[DataType]
, because that caused type havoc. Therefore, the default is changed fromNone
toDataType.AUTO
when not set explicitly. Thegtir_dtype_resolver
and other visitors are updated to check forDataType.AUTO
instead ofNone
.eve.iterators
toeve.concepts
to work around a circular dependency after solving ClassVar parameters cannot include any type variables #565 using @egparedes's suggestion. This is a temporary workaround until we replace Eve with the new version.gt4py.stencil_object.ArgsInfo
is made non-private and used ingt4py.dace_stencil_object
to fix a type issue.npir.HorizontalMask
is created as a tuple of tuples, to avoid theOptional[AxisBound]
in thecommon.HorizontalInterval
type.gt_backend
references withgt4py.backend
.Follows #978.
Resolves #565.
Resolves #992.
Resolves #1007.