Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[cartesian]: add extra_link_args for flexible support of various compiler build #1552

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

xyuan
Copy link

@xyuan xyuan commented Jun 11, 2024

add one more environment GT4PY_EXTRA_LINK_ARGS for flexible support of various compiler build (this contribution is not copyrightable as it's a trivial change)

<type>:
    - build: Changes that affect the build system or external dependencies
    - ci: Changes to our CI configuration files and scripts
    - style: Changes that do not affect the meaning of the code
    - test: Adding missing tests or correcting existing tests

<scope>: cartesian 
# ONLY if changes are limited to a specific subsytem
  • PR Description:
    add one more environment GT4PY_EXTRA_LINK_ARGS for flexible support of various compiler build

Requirements

  • All fixes and/or new features come with corresponding tests.
  • Important design decisions have been documented in the approriate ADR inside the docs/development/ADRs/ folder.

If this PR contains code authored by new contributors please make sure:

  • All the authors are covered by a valid contributor assignment agreement provided to ETH Zurich and signed by the employer if needed.
  • The PR contains an updated version of the AUTHORS.md file adding the names of all the new contributors.

@havogt havogt changed the title add extra_link_args for flexible support of various compiler build feat[cartesian]: add extra_link_args for flexible support of various compiler build Jun 12, 2024
@havogt
Copy link
Contributor

havogt commented Jun 12, 2024

Thank you for the contribution!

@xyuan
Copy link
Author

xyuan commented Jun 12, 2024

Thank you for the contribution!

thanks, I had thought there is workflow test before PR, but I didn't find it. yeah, I will follow these workflows for my new PR

@xyuan
Copy link
Author

xyuan commented Jun 12, 2024

the code pattern check here is interesting, we usually only check the code style, here is the output,

-extra_link_args: List[str] = (

  • list(GT4PY_EXTRA_LINK_ARGS.split(" ")) if GT4PY_EXTRA_LINK_ARGS else []
    -)
    +extra_link_args: List[str] = list(GT4PY_EXTRA_LINK_ARGS.split(" ")) if GT4PY_EXTRA_LINK_ARGS else []

however it is fine for extra_compile_args.

@havogt
Copy link
Contributor

havogt commented Jun 25, 2024

Can you write a short note here regarding this:

Please also confirm (by a comment in this PR) that this contribution is not copyrightable as it's a trivial change. We don't need you to sign the CAA in that case.

@xyuan
Copy link
Author

xyuan commented Jul 3, 2024

Can you write a short note here regarding this:

Please also confirm (by a comment in this PR) that this contribution is not copyrightable as it's a trivial change. We don't need you to sign the CAA in that case.

yes, I did

@havogt havogt merged commit 6bbedb1 into GridTools:main Jul 4, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants