Update dependencies to match those in 'functional' #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdahm
commented
Oct 14, 2022
Comment on lines
188
to
190
| if self.path_stats(self.path) != self.path_stats(str(self.module_file.absolute())): | ||
| assert fullname is not None | ||
| self.module_file.write_text(self.get_source_code(fullname)) |
There was a problem hiding this comment.
I wasn't quite sure how to handle this one, or how this function is used.
This was referenced Oct 14, 2022
jdahm
commented
Oct 19, 2022
Comment on lines
134
to
+135
| - repo: https://github.com/pre-commit/mirrors-mypy | ||
| rev: v0.812 | ||
| rev: v0.982 |
There was a problem hiding this comment.
Another option here is to use the one installed with requirements-dev.txt.
egparedes
reviewed
Oct 19, 2022
Co-authored-by: Enrique G. Paredes <18477+egparedes@users.noreply.github.com>
|
bors try |
tryBuild failed: |
|
bors try |
|
bors try |
tryAlready running a review |
|
bors try- |
tryBuild succeeded: |
jdahm
added a commit
that referenced
this pull request
Oct 26, 2022
Major changes: - Adds type checking on a few more files. - Expr.dtype's type is no longer Optional[DataType], because that caused type havoc. Therefore, the default is changed from None to DataType.AUTO when not set explicitly. The gtir_dtype_resolver and other visitors are updated to check for DataType.AUTO instead of None. - Moves most of the code that was in eve.iterators to eve.concepts to work around a circular dependency after solving ClassVar parameters cannot include any type variables #565 using @egparedes's suggestion. This is a temporary workaround until we replace Eve with the new version. - gt4py.stencil_object.ArgsInfo is made non-private and used in gt4py.dace_stencil_object to fix a type issue. - Ignores typing in eve visitor contexts -- need to fix that in a follow-up PR. - npir.HorizontalMask is created as a tuple of tuples, to avoid the Optional[AxisBound] in the common.HorizontalInterval type. - Replaces gt_backend references with gt4py.backend. Follows #978. Resolves #565. Resolves #992. Resolves #1007.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
... and fix the few errors that the new mypy version catches.