New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docs for Custom Filter function and Component #320

Merged
merged 1 commit into from Jan 24, 2016

Conversation

Projects
None yet
2 participants
@kevinhughes27
Contributor

kevinhughes27 commented Jan 19, 2016

Custom Filtering and a Custom Filter Component was added in #238. In this PR I am adding documentation and an example of how to use this awesome functionality based on my experience using it.

I couldn't see any info on how the docs work so hopefully I figured it out properly. Happy to make any changes required.

cc @tinygrasshopper in case you want to check the documentation for correctness

@ryanlanciaux

This comment has been minimized.

Member

ryanlanciaux commented Jan 20, 2016

Thanks so much for adding this -- it looks really good to me. I'll give it a little bit for @tinygrasshopper to chime in too but will merge soon. 👍

@kevinhughes27 kevinhughes27 force-pushed the kevinhughes27:custom-filter-docs branch from 32c2663 to c53913b Jan 20, 2016

@kevinhughes27 kevinhughes27 changed the title from Add Docs for Custom Filter functon and Component to Add Docs for Custom Filter function and Component Jan 20, 2016

@kevinhughes27

This comment has been minimized.

Contributor

kevinhughes27 commented Jan 21, 2016

Sounds good!

ryanlanciaux added a commit that referenced this pull request Jan 24, 2016

Merge pull request #320 from kevinhughes27/custom-filter-docs
Add Docs for Custom Filter function and Component

@ryanlanciaux ryanlanciaux merged commit a30f165 into GriddleGriddle:master Jan 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ryanlanciaux

This comment has been minimized.

Member

ryanlanciaux commented Jan 24, 2016

Thanks again for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment