Added (glow) ink sac to materials list for dyes #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jikoo
reviewed
Aug 6, 2021
| else if (material.name().endsWith("_DYE")) | ||
| else if (material.name().endsWith("_DYE") | ||
| || material.equals(Material.GLOW_INK_SAC) | ||
| || material.equals(Material.INK_SAC)) |
There was a problem hiding this comment.
Should add single special cases outside of the loop, no need to check every single time around. Also, you have mixed tabs and spaces.
There was a problem hiding this comment.
Ah, I see what you're talking about, I appreciate the heads up. This commit should address both issues.
RoboMWM
approved these changes
Aug 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in ink sacs and dyes to the materials checked for when using dyes on claims, requiring build permissions for players to use them; fixes #1457