Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added (glow) ink sac to materials list for dyes #1508

Merged
merged 2 commits into from Aug 8, 2021
Merged

Added (glow) ink sac to materials list for dyes #1508

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0206b85
Added (glow) ink sac to materials list for dyes
multirp Aug 5, 2021
1e5bf21
Removed ink sacs from for loop, adjusted formatting
multirp Aug 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/me/ryanhamshire/GriefPrevention/PlayerEventHandler.java
View file
Open in desktop
Expand Up @@ -1907,7 +1907,9 @@ else if (clickedBlock != null &&
if (material.isLegacy()) continue;
if (material.name().endsWith("_SPAWN_EGG"))
spawn_eggs.add(material);
else if (material.name().endsWith("_DYE"))
else if (material.name().endsWith("_DYE")
|| material.equals(Material.GLOW_INK_SAC)
|| material.equals(Material.INK_SAC))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add single special cases outside of the loop, no need to check every single time around. Also, you have mixed tabs and spaces.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see what you're talking about, I appreciate the heads up. This commit should address both issues.

dyes.add(material);
}

Expand Down