-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Migrate to Python3 ? #26
Comments
cool. Go ahead |
@Griffintaur I have submitted a PR, do you think you can take a look at it, thanks |
@Griffintaur depending on what you want, you might want to think about having the Python 2.7 version in a separate branch for those that don't use Python 3. |
Is this going to get merged? I noticed there are several unmerged PRs and master hasn't been updated in months. |
I know right, this is a little frustrating. If it is not merged after a week I'll make a separate repo. |
I was thinking of doing the same.
Aside from Python 3, I saw you did some cleanup, did you do anything with
filenames and pathing?
…On Sun, Feb 18, 2018, 6:44 PM Sam Redmond ***@***.***> wrote:
I know right, this is a little frustrating. If it is not merged after a
week I'll make a separate repo.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOQ4TL757EEjziSg7dh05qFYMOnehBZGks5tWMPzgaJpZM4R4dgt>
.
|
@TomFaulkner I have not changed file names/paths. If it helps, you can fork my copy: https://github.com/SillySam/News-At-Command-Line I will be happy to contribute to your copy as this guy doesn't seem to active. PS: I am just about to make another change on my fork that removes the owner's file headers and email, etc. |
@TomFaulkner I also want to note, when you make your own copy, please make your API key as I don't think the owner would like the key going viral :D |
Yeah, that is what I had in mind. Since moving to Python 3, without maintaining 2.7 compatibility is a breaking change, I think it would be a good time to make other breaking changes for PEP8 and a more pythonic ways of doing things. |
Since this was merged, I moved discussion to #30 so this issue can be closed. |
This would be great in Python 3, I think this would be appreciated.
The text was updated successfully, but these errors were encountered: