Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Migrate to Python3 ? #26

Open
ctrlsam opened this issue Feb 4, 2018 · 11 comments
Open

[Enhancement] Migrate to Python3 ? #26

ctrlsam opened this issue Feb 4, 2018 · 11 comments

Comments

@ctrlsam
Copy link

ctrlsam commented Feb 4, 2018

This would be great in Python 3, I think this would be appreciated.

@ctrlsam ctrlsam changed the title Migrate to Python3 ? [Enhancement] Migrate to Python3 ? Feb 4, 2018
@Griffintaur
Copy link
Owner

cool. Go ahead

@ctrlsam
Copy link
Author

ctrlsam commented Feb 5, 2018

@Griffintaur I have submitted a PR, do you think you can take a look at it, thanks

@ctrlsam
Copy link
Author

ctrlsam commented Feb 5, 2018

@Griffintaur depending on what you want, you might want to think about having the Python 2.7 version in a separate branch for those that don't use Python 3.

@TomFaulkner
Copy link

Is this going to get merged? I noticed there are several unmerged PRs and master hasn't been updated in months.

@ctrlsam
Copy link
Author

ctrlsam commented Feb 19, 2018

I know right, this is a little frustrating. If it is not merged after a week I'll make a separate repo.

@TomFaulkner
Copy link

TomFaulkner commented Feb 19, 2018 via email

@ctrlsam
Copy link
Author

ctrlsam commented Feb 19, 2018

@TomFaulkner I have not changed file names/paths. If it helps, you can fork my copy: https://github.com/SillySam/News-At-Command-Line

I will be happy to contribute to your copy as this guy doesn't seem to active.

PS: I am just about to make another change on my fork that removes the owner's file headers and email, etc.

@ctrlsam
Copy link
Author

ctrlsam commented Feb 19, 2018

@TomFaulkner I also want to note, when you make your own copy, please make your API key as I don't think the owner would like the key going viral :D

@TomFaulkner
Copy link

Yeah, that is what I had in mind. Since moving to Python 3, without maintaining 2.7 compatibility is a breaking change, I think it would be a good time to make other breaking changes for PEP8 and a more pythonic ways of doing things.

@TomFaulkner
Copy link

Posted this as a PR on @sillysam's fork. But, thought I would mention it here. I have a more Pythonic fork from @sillysam's fork. I cleaned up quite a bit, more still needs done, but it's posted at least. I plan to do more as I get time.

https://github.com/TomFaulkner/News-At-Command-Line

@TomFaulkner
Copy link

Since this was merged, I moved discussion to #30 so this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants