-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some patches, some ideas. #57
Conversation
Why should we move .grive to the home directory? I want to have one .grive file in every directory the user sync with Google Drive. A user can have multiple directories which contains multiple .grive files. |
It's not advised to clutter every directory, having a single database would be better. |
Many thanks for the patch. I merged but reverted 9a76cb8 in my branch. I have adjusted the indentation. I used tab characters instead of spaces. I hope you can follow. We can continue our discussion on why we want to move .grive to $HOME. |
Some people have multiple google accounts and multiple google drives, they may have multiple directories to sync and need different access tokens. That is why grive uses multiple .grive files in different directories. |
Use a single config file and let the user define in there the drives and the folder that should be synced/watched for each drive. Something like
A much saner approach than syncing the cwd :) |
That's a good idea! You want to write the code for it? |
Libgrive should be adjusted to not assume the cwd (".") as resource root but using the parent drive folder instead. |
Grive is using json-c right now. See libgrive/src/protocol/Json.cc |
This makes grive behave a bit better.
The resources shouldn't assume that "." is the path base to make the whole system flexible enough to make libgrive (and grive) useful. If the source Drive is stored into the Resource then you could build the full path by just appending the drive m_state path and all the parent names.