Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master React, Quick Code tutorial. Part 7 #8

Closed
7 tasks done
atherdon opened this issue Jun 12, 2018 · 9 comments
Closed
7 tasks done

Master React, Quick Code tutorial. Part 7 #8

atherdon opened this issue Jun 12, 2018 · 9 comments
Assignees

Comments

@atherdon
Copy link
Member

atherdon commented Jun 12, 2018

https://medium.com/quick-code/lets-learn-react-chapter-7-component-life-cycle-6aaa815747db

Expected result

  • Read this tutorial chapter
  • follow code steps
  • move your code to this repository(at least one commit per day)
  • explain to me, what did you learn from it in a few sentences(not less than 5)
  • pass the test section
  • after reviewing your progress and closing this issue - you can move to the next chapter.

Test

sanchit94 added a commit that referenced this issue Jun 28, 2018
@sanchit94 sanchit94 self-assigned this Jun 28, 2018
@sanchit94
Copy link
Collaborator

This tutorial talks about Component lifecycle, which are the set of actions that are performed before the component is mounted/rendered, after it is mounted, before it is updated and after it is updated. These funcitons will be useful in displaying data we get from the server. Here we have displayed dummy data that mimics our server data and used componentWillMount(). We can also perform some action when the component updates by using componentDidUpdate().

@atherdon
Copy link
Member Author

Can you create a PR with latest code changes?

@atherdon
Copy link
Member Author

@sanchit94 i think we did it, right?

@atherdon
Copy link
Member Author

if yes, can you put a code link where we adding meals, with all related fields to them? i'm not remembered, but i think the reason why i didn't close this task before because i didn't find an ingredients section. But i can be wrong, for sure...

@sanchit94
Copy link
Collaborator

Yes @atherdon the ingredient section was not there, so adding it right now.

@sanchit94
Copy link
Collaborator

The ingredients would be an array I suppose, I think this is a good time for us to move to ant design components as they will be more suitable for such inputs. Reactstrap has very few features to help with this. I want the ingredients to be a tag select as shown here https://ant.design/components/select/
Tell me what do you think.

@atherdon
Copy link
Member Author

atherdon commented Jul 14, 2018 via email

@sanchit94
Copy link
Collaborator

sanchit94 commented Jul 14, 2018 via email

@atherdon
Copy link
Member Author

Hmm, it can be Select2 plugin.
it's not in my priority right now, if you wish, you can try a few different options, and then show to me your results.
i'll be ok, if it'll be just multi-select for now. exntend your logic-vision - is my main goal for this task, not UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants