core: don't catch exception for parse fail #107
Conversation
When JSON/YAML parsing fails, you currently get a cryptic error indicating pykwalify was unable to load the file. It is much more helpful to see the actual parse error so that you can easily fix it. So, just let the exception through rather than swallowing it.
|
I updated the PR so that the tests pass now. The failing checks in Travis are caused by some issue installing ruamel and seem unrelated to this change. |
|
Hi, why did this pull request get closed? It looks like several others got closed as well. |
|
@martingkelly oh i missed that O.o i moved away from a master/unstable branch model to only use a master branch. I guess github decided to close all PR:s automatically when i removed the destinatino branch. It looks like i can't really reopen it and change the destination branch to master so you as the author has to do that manually if you want it open again -_- This was not my intent to happen |
|
Ah, makes sense. I'll rebase and push it again, then reopen the request. It looks like this happened to several other PRs, so you may want to let the other requesters know. |
|
The PR:s that is relevant to do that i will. Some of them i can merge manually and just mention that it was merged. |
|
See #116 for merged code |
I need to update the tests to not fail on this... will do soon.