Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

nodemanager to honor max_connections #180

Closed
wants to merge 2 commits into from

Conversation

deepakverma
Copy link

@deepakverma deepakverma commented Jan 25, 2017

It seems like that nodemanager doesn't honor max_connections set on a ClusterConnectionPool.

pool = ClusterConnectionPool(startup_nodes=[{'host': host, 'port': 6380}],
                             password=password,
                             max_connections_per_node=True,
                             max_connections=30,
                             socket_timeout=20,
                             socket_connect_timeout=10,
                             socket_keepalive=True,
                             )

With this pull requests Nodemanager would start passing the max_connections to StrictRedis

@coveralls
Copy link

coveralls commented Jan 27, 2017

Coverage Status

Coverage remained the same at 87.421% when pulling 77fd25f on deepakverma:unstable into fad035a on Grokzen:unstable.

@Grokzen
Copy link
Owner

Grokzen commented Feb 5, 2017

@deepakverma Question: Would it not make more sense to pass down the variable self.max_connections_per_node ??

@Grokzen
Copy link
Owner

Grokzen commented Feb 6, 2017

@deepakverma I merged this manually and added a line in the release notes. Find the commit here 2d3006c

Thanks for finding and reporting this :)

@Grokzen Grokzen closed this Feb 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants