Add SSLClusterConnection for connecting over TLS/SSL to Redis Cluster #183
Conversation
|
@dkent Looks good, straight forward and simple. One comment is to add yourself to authors list in docs/ if you like or not. I will have to read up on TLS/SSL certs and redis and give this a spin before merging but i see no real problems anyway :) When tested i will merge this. |
|
@dkent All 3.2 redis builds have problems on travis. Will have to wait until fixed before travis-ci passes. All 3.0 tests works tho. |
CHANGES
Outdated
| @@ -0,0 +1,3 @@ | |||
| Next release | |||
There was a problem hiding this comment.
@dkent Noticed one thing. you should not add this line to this file, you should add it to docs/release-notes.rst instead. Please move it there before i can merge this.
There was a problem hiding this comment.
Hopefully I made the change correctly. Thanks! :)
|
@dkent Except from the 1 comment in the code there is only one thing left to do and that is if you want add yourself to authors file. If not then please look at the comment and after that one is fixed i am ready to merge this. |
…me to authors file
|
@dkent There is some conflicts that you need to resolve now -_- you probably need to rebase on latest unstable |
rediscluster/connection.py
Outdated
| self.nodes = NodeManager( | ||
| startup_nodes, | ||
| reinitialize_steps=reinitialize_steps, | ||
| skip_full_coverage_check=skip_full_coverage_check, | ||
| max_connections=self.max_connections, | ||
| **connection_kwargs | ||
| ) |
There was a problem hiding this comment.
Looks like I made a mistake in the review screen. Fixing.
|
@dkent Ye i was pushing merges and changes myself so thats why your stuff broke :) sry for that |
|
@Grokzen No worries. I was overly optimistic. I generally fetch and rebase. |
No description provided.