Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Improve benchmark script. Add [-n <reqursts>] and [-c <concurrent>] o… #276

Merged
merged 4 commits into from
Jan 8, 2019

Conversation

jkklee
Copy link
Contributor

@jkklee jkklee commented Sep 14, 2018

Improve benchmark script. Add [-n ] and [-c ] options, multi clients test use multi processes modle

…ptions, multi clients test use multi processes modle
@coveralls
Copy link

coveralls commented Sep 14, 2018

Coverage Status

Coverage remained the same at 85.62% when pulling 2e21d14 on jkklee:unstable into a49d21a on Grokzen:unstable.

benchmarks/simple.py Outdated Show resolved Hide resolved
@Grokzen
Copy link
Owner

Grokzen commented Oct 2, 2018

@jkklee There is alot of code that you have commented out that needs to be brought back, all the timeit code for example and alot of stuff that you improved and is not needed but was not removed, that needs to be cleaned up. I like where it is going and i would like to get it in, but you need to fix some cleanup before i can merge this.

@Grokzen
Copy link
Owner

Grokzen commented Oct 2, 2018

A few other lines of cleanup you need to add is to update the docs in this section https://github.com/Grokzen/redis-py-cluster/blob/unstable/docs/benchmarks.rst

@jkklee
Copy link
Contributor Author

jkklee commented Oct 9, 2018

@Grokzen done, please check it.

benchmarks/simple.py Outdated Show resolved Hide resolved
benchmarks/simple.py Show resolved Hide resolved
benchmarks/simple.py Outdated Show resolved Hide resolved
Copy link
Owner

@Grokzen Grokzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes i require before i merge this. Looks good overall and i tested it locally and i am happy with the overall changes.

docs/benchmarks.rst Outdated Show resolved Hide resolved
benchmarks/simple.py Outdated Show resolved Hide resolved
benchmarks/simple.py Outdated Show resolved Hide resolved
benchmarks/simple.py Outdated Show resolved Hide resolved
docs/benchmarks.rst Outdated Show resolved Hide resolved
docs/benchmarks.rst Outdated Show resolved Hide resolved
benchmarks/simple.py Outdated Show resolved Hide resolved
benchmarks/simple.py Show resolved Hide resolved
@jkklee
Copy link
Contributor Author

jkklee commented Nov 2, 2018

@Grokzen sorry I'm not good at github's pull_requests

@Grokzen Grokzen merged commit 793734c into Grokzen:unstable Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants