-
Notifications
You must be signed in to change notification settings - Fork 316
Improve benchmark script. Add [-n <reqursts>] and [-c <concurrent>] o… #276
Conversation
…ptions, multi clients test use multi processes modle
@jkklee There is alot of code that you have commented out that needs to be brought back, all the timeit code for example and alot of stuff that you improved and is not needed but was not removed, that needs to be cleaned up. I like where it is going and i would like to get it in, but you need to fix some cleanup before i can merge this. |
A few other lines of cleanup you need to add is to update the docs in this section https://github.com/Grokzen/redis-py-cluster/blob/unstable/docs/benchmarks.rst |
@Grokzen done, please check it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes i require before i merge this. Looks good overall and i tested it locally and i am happy with the overall changes.
…liminate ambiguity of the output
@Grokzen sorry I'm not good at github's pull_requests |
Improve benchmark script. Add [-n ] and [-c ] options, multi clients test use multi processes modle