This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
Read replica single command support #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks appreciate you picking this up. I've been extremely busy with work and haven't had time to do this. |
|
@eshyong i will have a look at it |
|
Thanks @Grokzen! 👍 |
|
Hi @Grokzen, any update on this? |
|
hey @Grokzen any update on merging this in? |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up where @a34729t left off on his pull request: #271
This PR keeps the same code but fixes the tests; it looks like we needed to parse the response after sending the 'READONLY' command, and some call counts were off, so I removed them. It wasn't immediately clear what purpose the call counts served, so let me know if I should revert that.